Scope Creep PR #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "CharCreateAnim"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR includes
@ -6,0 +25,4 @@constexpr uintptr_t SPELL_VISUAL_KIT_DB_RECORDS_ADDRESS = 0x00AD4A54;constexpr uintptr_t SPELL_VISUAL_DB_RECORDS_ADDRESS = 0x00AD4AC0;constexpr uint32_t CHARACTER_CREATE_PREVIEW_ATTACHMENT = 0;constexpr uint32_t SPELL_ATTACHMENT_CHEST = 15;Move these to an enum in spells.h.
@ -6,0 +34,4 @@constexpr uint32_t SPELL_ATTACHMENT_SPECIAL_1 = 23;constexpr uint32_t SPELL_ATTACHMENT_SPECIAL_2 = 24;constexpr uint32_t SPELL_ATTACHMENT_SPECIAL_3 = 25;constexpr uint32_t SPELL_AURA_MOD_STEALTH = 16;I think there's already a spell aura enum in spells.h
@ -6,0 +161,4 @@float CharacterCreateAuraPreviewOriginalBlue = 1.0f;float CharacterCreateAuraPreviewOriginalAlpha = 1.0f;uint32_t ReadUInt32(std::string const& data, size_t offset)pending a message below; these are predicated on needing a raw read of the dbc rather than getting the client data row for the already loaded dbc.
@ -6,0 +180,4 @@std::unordered_map<uint32_t, std::string> LoadAnimationNames(){std::unordered_map<uint32_t, std::string> names;std::string const dbc = ClientMPQ::readFile("DBFilesClient\\AnimationData.dbc");Should prob just try to use a native already loaded dbc row getter here. GetRow or whatever, rather than a raw read.
@ -6,0 +71,4 @@uint32_t blendTime = 0;};struct SpellVisualRowThese should all be moved to clientData since they're dbc row structs
@ -6,0 +127,4 @@char* fileName;};struct C44MatrixJust the stuff above this per the last message
@ -6,0 +217,4 @@std::unordered_map<uint32_t, std::string> LoadSoundEntryPaths(){std::unordered_map<uint32_t, std::string> paths;std::string const dbc = ClientMPQ::readFile("DBFilesClient\\SoundEntries.dbc");same as above.
@ -6,0 +433,4 @@if (!model || !CM2Model__IsLoaded(model, 0, 0))return;uint32_t const attachments[] =would need to be updated when swapping to enum
@ -6,0 +539,4 @@return true;}uint32_t GetSpellVisualKitId(SpellVisualRow const& visual, uint32_t stage)genuine question: is there no native function for this?
@ -512,0 +635,4 @@COMBAT_ABILITY1_H03_OFF = 1320,COMBAT_ABILITY_DUAL_WIELD01 = 1322,CombatAbility2HBig02 = 1488,unknown1536 = 1536, // Kebful: Leaving this since Hater added it in.This is reading the map.
Scope Creep PRto WIP: Scope Creep PRWIP: Scope Creep PRto Scope Creep PRapproved